cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-15134) SASI index files not included in snapshots
Date Fri, 10 Sep 2021 17:47:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413310#comment-17413310
] 

Andres de la Peña commented on CASSANDRA-15134:
-----------------------------------------------

At first glance the approach looks good to me. There are still things that we have to do as
part of CEP-7, such as including the index components in incremental backups and making the
snapshot management implementation-agnostic, but I think that the proposed patch would give
us reasonable snapshotting functionality for SASI in the meantime.

The method {{SSTable#addComponents}} seems idempotent, so I think that having SASI registering
its components won't be a problem if we end up having a more generic mechanism to register
index components based on some future {{Index#getComponents()}} method.

[~jasonstack]/[~maedhroz] any thoughts on this?

I have left a few very minor comments on the PR, and I wonder whether we should add a simple
dtest taking and restoring an index snapshot, maybe [here|https://github.com/apache/cassandra-dtest/blob/trunk/snapshot_test.py].
That would be our first dtest for SASI ever.

> SASI index files not included in snapshots
> ------------------------------------------
>
>                 Key: CASSANDRA-15134
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15134
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/SASI, Local/Snapshots
>            Reporter: Vincent White
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Newly written SASI index files are not being included in snapshots. This is because the
SASI index files are not added to the components ({{org.apache.cassandra.io.sstable.SSTable#components}})
list of newly written sstables. 
> Although I don't believe anything except snapshots ever tries to reference the SASI index
files from this location, on startup Cassandra does add the SASI index files (if they are
found on disk) of existing sstables in their components list. In that case sstables that existed
on startup with SASI index files will have their SASI index files included in any snapshots.
>  
> This patch updates the components list of newly written sstable once the index is built.
> ||3.11||4.0||Trunk||
> |[https://github.com/apache/cassandra/pull/1150]|[TBD]|[TBD]|
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message