cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <>
Subject [jira] [Commented] (CASSANDRA-16841) Unexpectedly ignored dtests
Date Fri, 10 Sep 2021 11:33:00 GMT


Andres de la Peña commented on CASSANDRA-16841:

Thanks for the changes.

I have noticed that with the patch some tests are collected twice. Specifically, this happens
with the tests in {{TestBootstrap}} and {{TestBaseSStableLoader}}. These classes are extended
by upgrade tests classes in {{}} and {{}},
and they are collected both from their original class and from the upgrade test that extends

I am attaching a file with the differences in collected tests for different combinations of

> Unexpectedly ignored dtests
> ---------------------------
>                 Key: CASSANDRA-16841
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/python
>            Reporter: Ruslan Fomkin
>            Assignee: Ruslan Fomkin
>            Priority: Normal
>         Attachments: collected-dtests-diffs.txt
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
> An issue, which I was hit:
> When one class in a dtest file is marked as resource intensive, then all tests in all
classes are treated as resource intensive. For example, [repair_tests/|] contains
three classes and the last class is marked as resource intensive:
> {code:java}
> @pytest.mark.resource_intensive
> class TestRepairDataSystemTable(Tester):
> {code}
> So if I try to run an unmarked class: 
> {code:java}
> pytest --cassandra-dir=../cassandra repair_tests/ --collect-only
> {code}
> then all tests are ignored
> {code:java}
> collected 36 items / 36 deselected 
> {code}
> This is because a test is treated to be marked if any class in the same file has the
mark. This bug was introduced in the fix of CASS-16399. Before only upgrade tests had such
behaviour, i.e., if a class is marked as upgrade test, then all tests are upgrade test in
the file.
> This bug, for example, means that if the same file contains one class marked with vnodes
and another class with no_vnodes, then no tests will be executed in the file.
> I also noticed another issue that If a test run is executed with the argument {{-only-resource-intensive-tests}}
and there is no sufficient resources for resource intensive tests, then no tests were executed. Thus
it was necessary to provide {{-force-resource-intensive-tests}} in addition.
> Suggestions for the solutions:
>  # Require to mark each class and remove the special case of upgrade tests. This will
simplify the implementation and might be more obvious for new comers.
>  # Treat {{-only-resource-intensive-tests}} in the same way as {{-force-resource-intensive-tests}},
so it will be enough to just specify it even with no sufficient resources.
> *Update:* comments were provided to keep only the first suggestion and do not implement
the second suggestion. 

This message was sent by Atlassian Jira

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message