cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16844) Add number of sstables in a compaction to compactionstats output
Date Mon, 13 Sep 2021 16:26:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414288#comment-17414288
] 

Andres de la Peña commented on CASSANDRA-16844:
-----------------------------------------------

Looks good. I was thinking that perhaps we could name the new column "sstables" instead of
"count" if it's easier to understand what are we counting, I'm not sure about this. Also the
column could be immediately to the left of the "table" column, so the left part of the table
indicates what are we compacting and the right part of the table indicates the progress of
the compaction. For example:
{code:java}
id    compaction type keyspace table sstables completed total     unit  progress
(...) Compaction      k        t     2        189439592 422339911 bytes 44.85%  
{code}
Instead of
{code:java}
id    compaction type keyspace table completed total     unit  progress count
(...) Compaction      k        t     189439592 422339911 bytes 44.85%   2
{code}
Would it make any sense?

We will also need to update the [doc about {{compactionstats}}|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/doc/source/troubleshooting/use_nodetool.rst#compaction-state]
with the new column.
  

> Add number of sstables in a compaction to compactionstats output
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-16844
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16844
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Brendan Cicchi
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 4.x
>
>
> It would be helpful to know at a glance how many sstables are involved in any running
compactions. While this information can certainly be collected now, a user has to grab it
from the debug logs. I think it would be helpful for some use cases to have this information
straight from {{nodetool compactionstats}} and then if the actual sstables involved in the
compactions are desired, dive into the debug.log for that. I think it would also be good to
have this information in the output of {{nodetool compactionhistory}}.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message