cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16918) CQLTester open more java driver connections than required by the tests
Date Tue, 07 Sep 2021 12:38:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411201#comment-17411201
] 

Andres de la Peña commented on CASSANDRA-16918:
-----------------------------------------------

Looks good to me, +1.

The method {{CQLTester#requireNetworkWithoutDriver()}} was added during CASSANDRA-16758 to
fix {{ClientResourceLimitsTest}}. This patch makes that unnecessary, but [here|https://app.circleci.com/pipelines/github/adelapena/cassandra/833/workflows/507364e1-6342-4536-b03e-3be8a5f15353/jobs/8051]
and [here|https://app.circleci.com/pipelines/github/adelapena/cassandra/833/workflows/475d7872-f02e-4300-91f7-3e8c4177b960/jobs/8046]
are some multiplexed runs of that method just in case.

> CQLTester open more java driver connections than required by the tests
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-16918
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16918
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/unit
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When {{requireNetwork}} or {{reinitializeNetwork}} is called within a {{CQLTester}} unit
test the test will open 4 connections to the server (one for each protocol version) even if
the test only require a single connection.
> There are no good reasons for that behavior and the connections can simply be opened
on a lazy way. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message