cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-16959) nodetool setstreamthroughput accepts invalid arguments that are not immediately applied
Date Wed, 15 Sep 2021 14:28:00 GMT
Andres de la Peña created CASSANDRA-16959:
---------------------------------------------

             Summary: nodetool setstreamthroughput accepts invalid arguments that are not
immediately applied
                 Key: CASSANDRA-16959
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16959
             Project: Cassandra
          Issue Type: Bug
          Components: Tool/nodetool
            Reporter: Andres de la Peña
            Assignee: Andres de la Peña


Both {{nodetool setstreamthroughput}} and {{nodetool setinterdcstreamthroughput}} accept
a negative throughput. The throughput value is not immediately applied to the corresponding
rate limiters. Instead, the value is set in the {{Config}} and it's only applied to the singleton
rate limiter when new sstable stream writer are created, which could happen much later. By
then the setting of the new rate in the rate limiter will fail with an {{IllegalArgumentException}}
due to the negative value.

I think we should either immediately reject negative throughputs or consider them unlimited,
as we do with zero. Also we should probably apply the new throughput to the rate limiter immediately,
since I don't see why we should wait to start using the new throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message