cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16972) Fix org.apache.cassandra.cql3.ViewTest.testTruncateWhileBuilding
Date Thu, 23 Sep 2021 09:36:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419083#comment-17419083
] 

Andres de la Peña commented on CASSANDRA-16972:
-----------------------------------------------

I think that the check for the completion of the MV build completion [here|https://github.com/apache/cassandra/blob/ea3cca04eba8844a685142d7d3093b1aa58bb4eb/test/unit/org/apache/cassandra/cql3/ViewTest.java#L1486]
is not reliable in 3.0 and 3.11 because in those branches the views are built on the same
executor that is used for compaction and the number of pending compaction tasks is estimated.
That's not a problem in 4.0 and trunk because in those branches the MVs are built on their
own dedicated executor.

The proposed patch just removes the wait for the running compactions and instead waits for
the MV to be marked as built. That seems to survive 5000 runs of the {{ViewTest#testTruncateWhileBuilding}}
method and 2000 of for the entire {{ViewTest}} suite:

||branch||Multiplexed method||Multiplexed suite||
|[3.0|https://github.com/adelapena/cassandra/tree/16972-3.0]  |[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/872/workflows/08c3abc8-a7cc-41b7-adbe-4eb4ba5b3cfc/jobs/8379]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/883/workflows/d81e1df6-deb4-491e-883b-f22648246a44/jobs/8423]|
|[3.11|https://github.com/adelapena/cassandra/tree/16972-3.11] |[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/873/workflows/e918e933-af1c-44ee-bdc1-48ed04430f92/jobs/8370]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/881/workflows/105061d6-4f79-4e9e-ae6e-0568303b8096/jobs/8434]|
|[4.0|https://github.com/adelapena/cassandra/tree/16972-4.0]  |[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/875/workflows/58df4965-420e-4dc0-a53d-fdfc4cd6a931/jobs/8372]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/875/workflows/209aaa16-bcc0-48c6-ac41-a887f8853a4d/jobs/8375]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/882/workflows/94fb2e42-06b2-49a3-a68b-147cd531a0ba/jobs/8426]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/882/workflows/b6286f56-9589-4660-96f8-3b24773d00f0/jobs/8417]|
|[trunk|https://github.com/adelapena/cassandra/tree/16972-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/874/workflows/cb9da1da-95c6-4b32-b49f-4001efe41914/jobs/8376]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/874/workflows/07e5be80-2a8b-45d6-ab1c-81601dcf0110/jobs/8377]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/880/workflows/eba4b419-ecfa-4224-bc83-15936b3e2f8f/jobs/8428]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/880/workflows/8654441a-31d2-4d73-bc2b-b877602f22b1/jobs/8436]|



> Fix org.apache.cassandra.cql3.ViewTest.testTruncateWhileBuilding 
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-16972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16972
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Ekaterina Dimitrova
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 3.11.x
>
>
> [org.apache.cassandra.cql3.ViewTest.testTruncateWhileBuilding|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1119/testReport/junit/org.apache.cassandra.cql3/ViewTest/testTruncateWhileBuilding/] 
fails in 3.11
>  
> {code:java}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1> at org.apache.cassandra.Util.spinAssertEquals(Util.java:575)
at org.apache.cassandra.cql3.ViewTest.testTruncateWhileBuilding(ViewTest.java:1656) at org.jboss.byteman.contrib.bmunit.BMUnitRunner$9.evaluate(BMUnitRunner.java:342)
at org.jboss.byteman.contrib.bmunit.BMUnitRunner$6.evaluate(BMUnitRunner.java:241) at org.jboss.byteman.contrib.bmunit.BMUnitRunner$1.evaluate(BMUnitRunner.java:75)
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message