cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andres de la Peña (Jira) <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-16989) Add environment variables to CircleCI config generation script
Date Fri, 24 Sep 2021 16:15:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419869#comment-17419869
] 

Andres de la Peña commented on CASSANDRA-16989:
-----------------------------------------------

{quote}I had similar thoughts yesterday and maybe we can just add a note - "For the right
parameters, please, check the list of examples in config-2_1.yml"
{quote}
Good idea, I have added that line to the description of the argument. Regarding the list of
accepted env vars, I'm slowly becoming a believer in it. The env variable injection is quite
basic and lacks proper yaml parsing, and the replacement is applied to any list item, not
only env vars. So one could produce a little catastrophe in the config file by, for example,
using {{run}} as an env var. Indeed this is a dev tool and not something to be used by end
users, so probably we don't need too much validation. But given that we already have the check
list, and it is not too large, we could leave it as it is. I don't have a strong preference
either way.

> Add environment variables to CircleCI config generation script
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-16989
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16989
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CI
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The purpose of this ticket is adding arguments to the CircleCI config generation script
allowing to set the values specific environment variables such as {{DTEST_REPO}} or {{DTEST_BRANCH}}
in the generated {{.circleci/config.yml}} file. For example, we could generate a CircleCI
config file with MIDRES specifying a dtest repo and branch by running:
> {code}
> generate.sh -m \
>   -e DTEST_REPO=git://github.com/adelapena/cassandra-dtest.git \
>   -e DTEST_BRANCH=CASSANDRA-8272 
> {code}
> Or we could set the test multiplexer for repeating a specific test with HIGHRES:
> {code}
> generate.sh -h \
>   -e REPEATED_UTEST_TARGET=testsome \
>   -e REPEATED_UTEST_CLASS=org.apache.cassandra.cql3.ViewTest \
>   -e REPEATED_UTEST_METHODS=testCompoundPartitionKey,testStaticTable \
>   -e REPEATED_UTEST_COUNT=100
> {code}
> This can be useful on its own so we don't have to manually edit the {{config-2_1.yml}}/{{config.yml}},
and it can also be useful for automation scripts manipulating these files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message