cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zznate <...@git.apache.org>
Subject [GitHub] cassandra pull request #205: Add virtual tables for CASSANDRA-7622
Date Mon, 12 Mar 2018 22:26:12 GMT
Github user zznate commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/205#discussion_r173966458
  
    --- Diff: src/java/org/apache/cassandra/schema/TableMetadata.java ---
    @@ -552,22 +601,25 @@ public boolean equals(Object o)
             TableMetadata tm = (TableMetadata) o;
     
             return keyspace.equals(tm.keyspace)
    -            && name.equals(tm.name)
    -            && id.equals(tm.id)
    -            && partitioner.equals(tm.partitioner)
    -            && params.equals(tm.params)
    -            && flags.equals(tm.flags)
    -            && isView == tm.isView
    -            && columns.equals(tm.columns)
    -            && droppedColumns.equals(tm.droppedColumns)
    -            && indexes.equals(tm.indexes)
    -            && triggers.equals(tm.triggers);
    +                && name.equals(tm.name)
    +                && id.equals(tm.id)
    +                && partitioner.equals(tm.partitioner)
    +                && params.equals(tm.params)
    +                && flags.equals(tm.flags)
    +                && isView == tm.isView
    +                && columns.equals(tm.columns)
    +                && droppedColumns.equals(tm.droppedColumns)
    +                && indexes.equals(tm.indexes)
    +                && triggers.equals(tm.triggers)
    +                && isVirtual == tm.isVirtual
    +                && (virtualKlass == null || virtualKlass.equals(tm.virtualKlass));
    --- End diff --
    
    null class a legal state?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message