cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zznate <...@git.apache.org>
Subject [GitHub] cassandra pull request #205: Add virtual tables for CASSANDRA-7622
Date Mon, 12 Mar 2018 22:26:12 GMT
Github user zznate commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/205#discussion_r173965848
  
    --- Diff: src/java/org/apache/cassandra/schema/Schema.java ---
    @@ -713,20 +727,24 @@ private void dropView(ViewMetadata metadata)
     
         private void dropTable(TableMetadata metadata)
         {
    -        ColumnFamilyStore cfs = Keyspace.open(metadata.keyspace).getColumnFamilyStore(metadata.name);
    -        assert cfs != null;
    -        // make sure all the indexes are dropped, or else.
    -        cfs.indexManager.markAllIndexesRemoved();
    -        CompactionManager.instance.interruptCompactionFor(Collections.singleton(metadata),
true);
    -        if (DatabaseDescriptor.isAutoSnapshot())
    -            cfs.snapshot(Keyspace.getTimestampedSnapshotNameWithPrefix(cfs.name, ColumnFamilyStore.SNAPSHOT_DROP_PREFIX));
    -        CommitLog.instance.forceRecycleAllSegments(Collections.singleton(metadata.id));
    --- End diff --
    
    I'll go back and look through comments, but _can_ i drop a VT? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message