cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelsembwever <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #29: Remove doxygen and references to it
Date Tue, 15 May 2018 21:50:33 GMT
Github user michaelsembwever commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/29#discussion_r188447578
  
    --- Diff: CONTRIBUTING.md ---
    @@ -82,7 +62,6 @@ In some cases, we organize our test files by putting them in directories.
If you
     
     - When possible, you should use the assert functions from [`tools/assertions.py`](https://github.com/apache/cassandra-dtest/blob/master/tools/assertions.py).
     - When none of these are applicable, use python's built in [unittest assertions](https://docs.python.org/2/library/unittest.html#assert-methods).
    -- Naked assert statements should never be used, e.g. `assert True`
    --- End diff --
    
    Also took this out, as it's clearly not adhered to in the codebase.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message