cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 17:06:05 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r187474479
  
    --- Diff: src/java/org/apache/cassandra/db/ReadCommand.java ---
    @@ -128,6 +130,7 @@ protected ReadCommand(Kind kind,
     
         protected abstract void serializeSelection(DataOutputPlus out, int version) throws
IOException;
         protected abstract long selectionSerializedSize(int version);
    +    public abstract Replica decorateEndpoint(InetAddressAndPort endpoint);
    --- End diff --
    
    I'm not sure if this is a good idea based on it being used after we have already committed
to that endpoint replicating a specific range a specific way. This seems like it races with
ring changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message