cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 17:06:05 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r187726766
  
    --- Diff: src/java/org/apache/cassandra/locator/AbstractEndpointSnitch.java ---
    @@ -23,17 +23,17 @@
     
     public abstract class AbstractEndpointSnitch implements IEndpointSnitch
     {
    -    public abstract int compareEndpoints(InetAddressAndPort target, InetAddressAndPort
a1, InetAddressAndPort a2);
    +    public abstract int compareEndpoints(InetAddressAndPort target, Replica r1, Replica
r2);
    --- End diff --
    
    Are they endpoints or replicas now? I think maybe this should just be endpoints to make
explicit the snitch isn't going to use the range or transient information. It doesn't have
many usages so it's not a big deal to manually


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message