cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 17:06:05 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r187710393
  
    --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java ---
    @@ -176,25 +179,28 @@ public void addSourceFilter(ISourceFilter filter)
          * Add ranges to be streamed for given keyspace.
          *
          * @param keyspaceName keyspace name
    -     * @param ranges ranges to be streamed
    +     * @param replicas ranges to be streamed
          */
    -    public void addRanges(String keyspaceName, Collection<Range<Token>> ranges)
    +    public void addRanges(String keyspaceName, Replicas replicas)
    --- End diff --
    
    Should this be addReplicas? I would also change the comment to ranges to be fetched. Streaming
seems to get used to imply both sending and fetching. But fetching always means fetching.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message