cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 17:06:10 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r188451194
  
    --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java ---
    @@ -1098,7 +1095,7 @@ private static void asyncRemoveFromBatchlog(Collection<InetAddressAndPort>
endpo
                     logger.trace("Sending batchlog remove request {} to {}", uuid, target);
     
                 if (canDoLocalRequest(target))
    -                performLocally(Stage.MUTATION, () -> BatchlogManager.remove(uuid));
    +                performLocally(Stage.MUTATION, Replica.fullStandin(target), () ->
BatchlogManager.remove(uuid));
    --- End diff --
    
    Full stand in! Either a replica is necessary downstream or it isn't. I checked and to
me it sure looks necessary because we use this to decide who to hint to and the decision of
should we hint or not is based on the transient state.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message