cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 17:06:10 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r188699158
  
    --- Diff: test/long/org/apache/cassandra/locator/DynamicEndpointSnitchLongTest.java ---
    @@ -54,19 +54,19 @@ public void testConcurrency() throws InterruptedException, IOException,
Configur
                 DynamicEndpointSnitch dsnitch = new DynamicEndpointSnitch(ss, String.valueOf(ss.hashCode()));
                 InetAddressAndPort self = FBUtilities.getBroadcastAddressAndPort();
     
    -            List<InetAddressAndPort> hosts = new ArrayList<>();
    +            ReplicaList replicas = new ReplicaList();
                 // We want a big list of hosts so  sorting takes time, making it much more
likely to reproduce the
                 // problem we're looking for.
                 for (int i = 0; i < 100; i++)
                     for (int j = 0; j < 256; j++)
    -                    hosts.add(InetAddressAndPort.getByAddress(new byte[]{ 127, 0, (byte)i,
(byte)j}));
    +                    replicas.add(Replica.fullStandin(InetAddressAndPort.getByAddress(new
byte[]{ 127, 0, (byte)i, (byte)j})));
    --- End diff --
    
    Full standin, can we avoid it? Seems like the snitch is generally not concerned with either
transientness or ranges just endpoints so we should need to have it using replicas?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message