cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 17:06:10 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r188361596
  
    --- Diff: src/java/org/apache/cassandra/locator/Replicas.java ---
    @@ -0,0 +1,313 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.locator;
    +
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Set;
    +
    +import com.google.common.base.Predicate;
    +import com.google.common.collect.Iterables;
    +import com.google.common.collect.Sets;
    +
    +import org.apache.cassandra.dht.Range;
    +import org.apache.cassandra.dht.Token;
    +import org.apache.cassandra.utils.FBUtilities;
    +
    +/**
    + * A collection like class for Replica objects. Since the Replica class contains inetaddress,
range, and
    + * transient replication status, basic contains and remove methods can be ambiguous.
Replicas forces you
    + * to be explicit about what you're checking the container for, or removing from it.
    + */
    +public abstract class Replicas implements Iterable<Replica>
    +{
    +
    +    public abstract boolean add(Replica replica);
    +    public abstract void addAll(Iterable<Replica> replicas);
    +    public abstract void removeEndpoint(InetAddressAndPort endpoint);
    +    public abstract void removeReplica(Replica replica);
    +    public abstract int size();
    +
    +    public Iterable<InetAddressAndPort> asEndpoints()
    +    {
    +        return Iterables.transform(this, Replica::getEndpoint);
    +    }
    +
    +    public Set<InetAddressAndPort> asEndpointSet()
    +    {
    +        Set<InetAddressAndPort> result = Sets.newHashSetWithExpectedSize(size());
    +        for (Replica replica: this)
    +        {
    +            result.add(replica.getEndpoint());
    +        }
    +        return result;
    +    }
    +
    +    public List<InetAddressAndPort> asEndpointList()
    +    {
    +        List<InetAddressAndPort> result = new ArrayList<>(size());
    +        for (Replica replica: this)
    +        {
    +            result.add(replica.getEndpoint());
    +        }
    +        return result;
    +    }
    +
    +    public Iterable<Range<Token>> asRanges()
    +    {
    +        return Iterables.transform(this, Replica::getRange);
    +    }
    +
    +    public Set<Range<Token>> asRangeSet()
    +    {
    +        Set<Range<Token>> result = Sets.newHashSetWithExpectedSize(size());
    +        for (Replica replica: this)
    +        {
    +            result.add(replica.getRange());
    +        }
    +        return result;
    +    }
    +
    +    public Iterable<Range<Token>> fullRanges()
    +    {
    +        return Iterables.transform(Iterables.filter(this, Replica::isFull), Replica::getRange);
    +    }
    +
    +    public boolean containsEndpoint(InetAddressAndPort endpoint)
    +    {
    +        return Iterables.any(this, r -> r.getEndpoint().equals(endpoint));
    --- End diff --
    
    This allocates a lambda. Also ReplicaList can implement this without allocating an iterator.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message