cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 19:35:39 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r188747102
  
    --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java ---
    @@ -23,196 +23,176 @@
     import com.google.common.collect.Iterators;
     import org.apache.cassandra.dht.Range;
     import org.apache.cassandra.dht.Token;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
     
     import java.util.*;
     
    -public class PendingRangeMaps implements Iterable<Map.Entry<Range<Token>,
List<InetAddressAndPort>>>
    +public class PendingRangeMaps implements Iterable<Map.Entry<Range<Token>,
List<Replica>>>
    --- End diff --
    
    Should this be consistent and stick to ReplicaList so we don't accidentally emit List<Replica>
into the rest of Cassandra?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message