cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdeggleston <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Wed, 16 May 2018 23:24:25 GMT
Github user bdeggleston commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r188800538
  
    --- Diff: src/java/org/apache/cassandra/batchlog/BatchlogManager.java ---
    @@ -490,16 +497,16 @@ private static int gcgs(Collection<Mutation> mutations)
             {
                 private final Set<InetAddressAndPort> undelivered = Collections.newSetFromMap(new
ConcurrentHashMap<>());
     
    -            ReplayWriteResponseHandler(Collection<InetAddressAndPort> writeEndpoints,
long queryStartNanoTime)
    +            ReplayWriteResponseHandler(Replicas writeReplicas, long queryStartNanoTime)
                 {
    -                super(writeEndpoints, Collections.<InetAddressAndPort>emptySet(),
null, null, null, WriteType.UNLOGGED_BATCH, queryStartNanoTime);
    -                undelivered.addAll(writeEndpoints);
    +                super(writeReplicas, ReplicaList.of(), null, null, null, WriteType.UNLOGGED_BATCH,
queryStartNanoTime);
    +                Iterables.addAll(undelivered, writeReplicas.asEndpoints());
    --- End diff --
    
    asEndpoints / asRanges doesn't allocate a new list, it just transforms the iterable


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message