cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdeggleston <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Thu, 17 May 2018 16:56:56 GMT
Github user bdeggleston commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r189030217
  
    --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java ---
    @@ -0,0 +1,121 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.locator;
    +
    +import java.util.Objects;
    +
    +import com.google.common.base.Preconditions;
    +
    +import org.apache.cassandra.config.DatabaseDescriptor;
    +
    +public class ReplicationFactor
    +{
    +    public static final ReplicationFactor ZERO = new ReplicationFactor(0);
    +
    +    public final int trans;
    +    public final int replicas;
    +    public transient final int full;
    --- End diff --
    
    I think I did that as sort of a hint that it's always calculated in the ctor as a convenience.
Since rf is defined as `all_replicas/trans_replicas`, and the `full` value is never provided
by the caller.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message