cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdeggleston <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Thu, 17 May 2018 21:33:35 GMT
Github user bdeggleston commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r189108331
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -591,8 +592,9 @@ public void run()
     
                     if (expiredCallbackInfo.shouldHint())
                     {
    -                    Mutation mutation = ((WriteCallbackInfo) expiredCallbackInfo).mutation();
    -                    return StorageProxy.submitHint(mutation, expiredCallbackInfo.target,
null);
    +                    WriteCallbackInfo writeCallbackInfo = ((WriteCallbackInfo) expiredCallbackInfo);
    +                    Mutation mutation = writeCallbackInfo.mutation();
    --- End diff --
    
    we need to get both the mutation and the replica out of the write callback info here


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message