cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdeggleston <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Thu, 17 May 2018 22:14:49 GMT
Github user bdeggleston commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r189117008
  
    --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java ---
    @@ -541,12 +536,12 @@ public void run()
             return callback;
         }
     
    -    private static boolean proposePaxos(Commit proposal, List<InetAddressAndPort>
endpoints, int requiredParticipants, boolean timeoutIfPartial, ConsistencyLevel consistencyLevel,
long queryStartNanoTime)
    +    private static boolean proposePaxos(Commit proposal, ReplicaList replicas, int requiredParticipants,
boolean timeoutIfPartial, ConsistencyLevel consistencyLevel, long queryStartNanoTime)
         throws WriteTimeoutException
         {
    -        ProposeCallback callback = new ProposeCallback(endpoints.size(), requiredParticipants,
!timeoutIfPartial, consistencyLevel, queryStartNanoTime);
    +        ProposeCallback callback = new ProposeCallback(replicas.size(), requiredParticipants,
!timeoutIfPartial, consistencyLevel, queryStartNanoTime);
             MessageOut<Commit> message = new MessageOut<Commit>(MessagingService.Verb.PAXOS_PROPOSE,
proposal, Commit.serializer);
    -        for (InetAddressAndPort target : endpoints)
    +        for (InetAddressAndPort target : replicas.asEndpoints())
    --- End diff --
    
    fixed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message