cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdeggleston <...@git.apache.org>
Subject [GitHub] cassandra pull request #224: 14405 replicas
Date Fri, 18 May 2018 21:04:15 GMT
Github user bdeggleston commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r189392952
  
    --- Diff: src/java/org/apache/cassandra/dht/RangeFetchMapCalculator.java ---
    @@ -347,15 +349,16 @@ else if (vertex.isRangeVertex())
         private boolean addEndpoints(MutableCapacityGraph<Vertex, Integer> capacityGraph,
RangeVertex rangeVertex, boolean localDCCheck)
         {
             boolean sourceFound = false;
    -        for (InetAddressAndPort endpoint : rangesWithSources.get(rangeVertex.getRange()))
    +        Replicas.checkFull(rangesWithSources.get(rangeVertex.getRange()));
    +        for (Replica replica : rangesWithSources.get(rangeVertex.getRange()))
             {
    -            if (passFilters(endpoint, localDCCheck))
    +            if (passFilters(replica, localDCCheck))
                 {
                     sourceFound = true;
                     // if we pass filters, it means that we don't filter away localhost and
we can count it as a source:
    -                if (endpoint.equals(FBUtilities.getBroadcastAddressAndPort()))
    +                if (replica.getEndpoint().equals(FBUtilities.getBroadcastAddressAndPort()))
    --- End diff --
    
    good idea, changed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message