cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #228: Add option to sanity check tombstones on reads/...
Date Wed, 30 May 2018 17:31:10 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/228#discussion_r191851543
  
    --- Diff: test/unit/org/apache/cassandra/db/compaction/CompactionsCQLTest.java ---
    @@ -245,6 +256,174 @@ public void testPerCFSNeverPurgeTombstones() throws Throwable
             testPerCFSNeverPurgeTombstonesHelper(false);
         }
     
    +    @Test
    +    public void testCompactionInvalidRTs() throws Throwable
    +    {
    +        DatabaseDescriptor.setCorruptedTombstoneStrategy(Config.CorruptedTombstoneStrategy.exception);
    +        prepare();
    +        RangeTombstone rt = new RangeTombstone(Slice.ALL, new DeletionTime(System.currentTimeMillis(),
-1));
    --- End diff --
    
    For each test case can you explain exactly what field you are setting that is invalid
and then ELI5 reason why that value isn't valid.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message