cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Fri, 13 Jul 2018 21:28:38 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r202477311
  
    --- Diff: src/java/org/apache/cassandra/db/DiskBoundaries.java ---
    @@ -129,4 +129,19 @@ public int getBoundariesFromSSTableDirectory(Descriptor descriptor)
         {
             return directories.get(getDiskIndex(sstable));
         }
    +
    +    public Directories.DataDirectory getCorrectDiskForKey(DecoratedKey key)
    +    {
    +        if (positions == null)
    +            return null;
    +
    +        return directories.get(getDiskIndex(key));
    +    }
    +
    +    private int getDiskIndex(DecoratedKey key)
    +    {
    +        int pos = Collections.binarySearch(positions, key);
    --- End diff --
    
    This method is pretty much a replica of `getDiskIndex(SSTableReader sstable)` (See: https://github.com/dineshjoshi/cassandra/blob/657ce3670a5291decf2939d72d51abe19333ef15/src/java/org/apache/cassandra/db/DiskBoundaries.java#L102)
Instead of accepting a sstable, I pass in a `DecoratedKey`.
    
    We ensure that the range is owned at the upper levels of the stack.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message