cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Fri, 13 Jul 2018 21:30:01 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r202477596
  
    --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
    @@ -211,12 +228,16 @@ public void serialize(CassandraStreamHeader header, DataOutputPlus
out, int vers
     
                 SerializationHeader.serializer.serialize(header.version, header.header, out);
     
    +            header.tableId.serialize(out);
                 out.writeBoolean(header.fullStream);
    +
                 if (header.fullStream)
                 {
                     out.writeInt(header.components.size());
                     for (ComponentInfo info : header.components)
                         ComponentInfo.serializer.serialize(info, out, version);
    +
    +                ByteBufferUtil.writeWithShortLength(header.firstKey.getKey(), out);
    --- End diff --
    
    Yes, this is the first situation where we're actually serializing `DecoratedKeys`. I am
not sure if it'll overflow.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message