cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasobrown <...@git.apache.org>
Subject [GitHub] cassandra pull request #236: 9608 trunk
Date Mon, 23 Jul 2018 11:58:16 GMT
Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/236#discussion_r204355461
  
    --- Diff: build.xml ---
    @@ -66,8 +67,14 @@
     
         <property name="doc.dir" value="${basedir}/doc"/>
     
    -    <property name="source.version" value="1.8"/>
    -    <property name="target.version" value="1.8"/>
    +    <!--
    +    We specific '8' instead of '1.8' in source.version to indicate that that this build
requires Java 11 _and_ Java 8.
    --- End diff --
    
    petty nit: `We specify`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message