cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamaleksey <>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Mon, 23 Jul 2018 20:11:42 GMT
Github user iamaleksey commented on a diff in the pull request:
    --- Diff: src/java/org/apache/cassandra/db/streaming/ ---
    @@ -0,0 +1,97 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.cassandra.db.streaming;
    +import org.apache.commons.lang3.builder.EqualsBuilder;
    +import org.apache.commons.lang3.builder.HashCodeBuilder;
    +import org.apache.cassandra.db.TypeSizes;
    +public class ComponentInfo
    --- End diff --
    Now, if you look carefully at all current uses of `ComponentInfo`, you'll see that it's
only ever being used as an element of lists, and never as a separate entity. As such it would
be cleaner - and nicer to work with - to implement a class, say, `ComponentManifest` that
would have an ordered map of `Component.Type` to `long` size, and expose the ordered keyset,
with serializers for the whole manifest. As it's written now, ser/deser code is leaking outside,
while it could instead be nicely encapsulated here.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message