cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamaleksey <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Tue, 24 Jul 2018 16:49:51 GMT
Github user iamaleksey commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r204831709
  
    --- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
    @@ -66,7 +66,7 @@
         private final LogReplicaSet replicas = new LogReplicaSet();
     
         // The transaction records, this set must be ORDER PRESERVING
    -    private final LinkedHashSet<LogRecord> records = new LinkedHashSet<>();
    +    private final Set<LogRecord> records = Collections.synchronizedSet(new LinkedHashSet<>());
// TODO: Hack until we fix CASSANDRA-14554
    --- End diff --
    
    I'm not very well familiar with `LifeCycleTransaction` code, but I'm not sure this is
sufficient as a workaround. @belliottsmith Could you please confirm that this - or isn't -
sufficient? Here and the equivalent change to `LogReplicaSet`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message