cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Wed, 25 Jul 2018 00:54:16 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r204954729
  
    --- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java ---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.db.streaming;
    +
    +import java.io.IOException;
    +
    +import org.apache.commons.lang3.builder.EqualsBuilder;
    +import org.apache.commons.lang3.builder.HashCodeBuilder;
    +import org.apache.cassandra.db.TypeSizes;
    +import org.apache.cassandra.io.IVersionedSerializer;
    +import org.apache.cassandra.io.sstable.Component;
    +import org.apache.cassandra.io.util.DataInputPlus;
    +import org.apache.cassandra.io.util.DataOutputPlus;
    +
    +public class ComponentInfo
    +{
    +    final Component.Type type;
    +    final long length;
    +
    +    public ComponentInfo(Component.Type type, long length)
    +    {
    +        assert length >= 0 : "Component length cannot be negative";
    +        this.type = type;
    +        this.length = length;
    +    }
    +
    +    @Override
    +    public String toString()
    +    {
    +        return "ComponentInfo{" +
    +               "type=" + type +
    +               ", length=" + length +
    +               '}';
    +    }
    +
    +    public boolean equals(Object o)
    --- End diff --
    
    `CassandraStreamHeader`'s `equals()` and `hashCode()` method are not dead code. They're
used in `CassandraStreamHeaderTest::serializerTest` which eventually ends up in [`SerializationUtils::assertSerializationCycle`](https://github.com/apache/cassandra/blob/9714a7c817b64a3358f69e536535c756c5c6df48/test/unit/org/apache/cassandra/serializers/SerializationUtils.java#L60).
This is what originally forced me to implement those methods. The only other choice was to
test the equality for `ComponentInfo` in `CassandraStreamHeader::equal()` which would have
been a bad choice.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message