cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Wed, 25 Jul 2018 06:53:48 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r204998639
  
    --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java ---
    @@ -62,7 +90,23 @@ public CassandraOutgoingFile(StreamOperation operation, Ref<SSTableReader>
ref,
                                                     sections,
                                                     sstable.compression ? sstable.getCompressionMetadata()
: null,
                                                     keepSSTableLevel ? sstable.getSSTableLevel()
: 0,
    -                                                sstable.header.toComponent());
    +                                                sstable.header.toComponent(), manifest,
shouldStreamFullSSTable(),
    +                                                sstable.first,
    +                                                sstable.metadata().id);
    +    }
    +
    +    @VisibleForTesting
    +    public static ComponentManifest getComponentManifest(SSTableReader sstable)
    +    {
    +        LinkedHashMap<Component.Type, Long> components = new LinkedHashMap<>(STREAM_COMPONENTS.size());
    +        for (Component component : STREAM_COMPONENTS)
    --- End diff --
    
    @iamaleksey would it be worth having a list of required components here? Any one of the
missing components will be a fatal? For example, when I reset the level on the receiving side,
I expect stats to exist and is sent over.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message