cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamaleksey <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Wed, 25 Jul 2018 21:59:44 GMT
Github user iamaleksey commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r205275733
  
    --- Diff: src/java/org/apache/cassandra/db/compaction/Verifier.java ---
    @@ -361,12 +361,26 @@ public RangeOwnHelper(List<Range<Token>> normalizedRanges)
              * @throws RuntimeException if the key is not contained
              */
             public void check(DecoratedKey key)
    +        {
    +            if (!checkBoolean(key))
    --- End diff --
    
    Please don't avoid it - unless it's in public API. Change as many layers as necessary,
in general, until the new code fits into the big picture. We allow and welcome it here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message