cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamaleksey <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Thu, 26 Jul 2018 15:36:54 GMT
Github user iamaleksey commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r205504297
  
    --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
    @@ -65,18 +85,43 @@ private CassandraStreamHeader(Version version, SSTableFormat.Type
format, long e
             this.compressionInfo = compressionInfo;
             this.sstableLevel = sstableLevel;
             this.header = header;
    -
    +        this.fullStream = fullStream;
    +        this.componentManifest = componentManifest;
    +        this.firstKey = firstKey;
    +        this.tableId = tableId;
             this.size = calculateSize();
         }
     
    -    public CassandraStreamHeader(Version version, SSTableFormat.Type format, long estimatedKeys,
List<SSTableReader.PartitionPositionBounds> sections, CompressionMetadata compressionMetadata,
int sstableLevel, SerializationHeader.Component header)
    +    private CassandraStreamHeader(Version version, SSTableFormat.Type format, long estimatedKeys,
    --- End diff --
    
    The introduction of the new fields and constructors got us to 5 constructors total with
up to 10 arguments, which is no longer manageable, and calls for a builder. It's boring and
tedious work, so I did it myself and pushed here - 
    https://github.com/iamaleksey/cassandra/commit/321d21747faa46afcf34518ebdeb811f2a805de8
- please feel free to cherry-pick.
    
    In addition to introducing the builder, the commit renames `fullStream` to something a
bit more meaningful (`isEntireSSTable`) that clearly reflects what's actually happening, fixes
a bug in `serializedSize()` where compression info isn't initialized, and removes some fields
without `toString()` implementations from header's own `toString()`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message