cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming
Date Thu, 26 Jul 2018 17:04:06 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r205532001
  
    --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
    @@ -183,9 +261,26 @@ public CassandraStreamHeader deserialize(DataInputPlus in, int version)
throws I
                     sections.add(new SSTableReader.PartitionPositionBounds(in.readLong(),
in.readLong()));
                 CompressionInfo compressionInfo = CompressionInfo.serializer.deserialize(in,
version);
                 int sstableLevel = in.readInt();
    +
                 SerializationHeader.Component header =  SerializationHeader.serializer.deserialize(sstableVersion,
in);
     
    -            return new CassandraStreamHeader(sstableVersion, format, estimatedKeys, sections,
compressionInfo, sstableLevel, header);
    +            TableId tableId = TableId.deserialize(in);
    +            boolean fullStream = in.readBoolean();
    +            ComponentManifest manifest = null;
    +            DecoratedKey firstKey = null;
    +
    +            if (fullStream)
    +            {
    +                manifest = ComponentManifest.serializer.deserialize(in, version);
    +                ByteBuffer keyBuf = ByteBufferUtil.readWithVIntLength(in);
    +                IPartitioner partitioner = partitionerMapper.apply(tableId);
    +                if (partitioner == null)
    +                    throw new IllegalArgumentException(String.format("Could not determine
partitioner for tableId {}", tableId));
    --- End diff --
    
    Fixed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message