cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamaleksey <...@git.apache.org>
Subject [GitHub] cassandra pull request #242: Expose settings in virtual table for CASSANDRA-...
Date Tue, 14 Aug 2018 17:37:22 GMT
Github user iamaleksey commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/242#discussion_r210040424
  
    --- Diff: src/java/org/apache/cassandra/audit/AuditLogOptions.java ---
    @@ -58,4 +61,11 @@
          * For more options, refer: net.openhft.chronicle.queue.RollCycles
          */
         public String roll_cycle = "HOURLY";
    +
    +    public String toString()
    --- End diff --
    
    Is this the `toString()` implementation we want? Like the other three, it's missing fields,
intentionally or not (if intentionally, maybe comment why so?). Also, this string helper prefixes
the map with the class name, and it doesn't look pretty in CQL output, subjectively.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message