cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #244: Refactor and add samplers for CASSANDRA-14436
Date Thu, 16 Aug 2018 06:34:46 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/244#discussion_r210487821
  
    --- Diff: src/java/org/apache/cassandra/db/ReadExecutionController.java ---
    @@ -90,11 +100,11 @@ static ReadExecutionController forCommand(ReadCommand command)
                 try
                 {
                     baseOp = baseCfs.readOrdering.start();
    -                indexController = new ReadExecutionController(indexCfs.readOrdering.start(),
indexCfs.metadata(), null, null);
    +                indexController = new ReadExecutionController(command, indexCfs.readOrdering.start(),
indexCfs.metadata(), null, null);
                     // TODO: this should perhaps not open and maintain a writeOp for the
full duration, but instead only *try* to delete stale entries, without blocking if there's
no room
                     // as it stands, we open a writeOp and keep it open for the duration
to ensure that should this CF get flushed to make room we don't block the reclamation of any
room being made
                     writeContext = baseCfs.keyspace.getWriteHandler().createContextForRead();
    -                return new ReadExecutionController(baseOp, baseCfs.metadata(), indexController,
writeContext);
    +                result =  new ReadExecutionController(command, baseOp, baseCfs.metadata(),
indexController, writeContext);
    --- End diff --
    
    Nit: Extra space.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message