cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasobrown <...@git.apache.org>
Subject [GitHub] cassandra pull request #255: Marcuse/14618
Date Wed, 29 Aug 2018 06:27:36 GMT
Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/255#discussion_r213547995
  
    --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQueryIterator.java ---
    @@ -0,0 +1,71 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.tools.fqltool;
    +
    +import java.util.PriorityQueue;
    +
    +import net.openhft.chronicle.queue.ExcerptTailer;
    +import org.apache.cassandra.utils.AbstractIterator;
    +
    +public class FQLQueryIterator extends AbstractIterator<FQLQuery>
    +{
    +    private final PriorityQueue<FQLQuery> pq;
    --- End diff --
    
    Please add a small comment here as to why a `PriorityQueue` ("so we can sort the entries
by timestamp of the query in logs, not just the order in the file"). This would just be a
nice, quick little helper.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message