cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #255: Marcuse/14618
Date Wed, 29 Aug 2018 07:04:01 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/255#discussion_r213562817
  
    --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java ---
    @@ -0,0 +1,263 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.tools.fqltool;
    +
    +import java.nio.ByteBuffer;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Objects;
    +import java.util.stream.Collectors;
    +
    +import com.google.common.primitives.Longs;
    +import com.google.common.util.concurrent.FluentFuture;
    +import com.google.common.util.concurrent.Futures;
    +import com.google.common.util.concurrent.ListenableFuture;
    +import com.google.common.util.concurrent.MoreExecutors;
    +
    +import com.datastax.driver.core.BatchStatement;
    +import com.datastax.driver.core.ConsistencyLevel;
    +import com.datastax.driver.core.ResultSet;
    +import com.datastax.driver.core.ResultSetFuture;
    +import com.datastax.driver.core.Session;
    +import com.datastax.driver.core.SimpleStatement;
    +import org.apache.cassandra.audit.FullQueryLogger;
    +import org.apache.cassandra.cql3.QueryOptions;
    +import org.apache.cassandra.utils.ByteBufferUtil;
    +import org.apache.cassandra.utils.binlog.BinLog;
    +
    +public abstract class FQLQuery implements Comparable<FQLQuery>
    +{
    +    public final long queryTime;
    +    public final QueryOptions queryOptions;
    +    public final int protocolVersion;
    +    public final String keyspace;
    +
    +    public FQLQuery(String keyspace, int protocolVersion, QueryOptions queryOptions,
long queryTime)
    --- End diff --
    
    Is there a reason why you didn't use `o.a.c.t.ProtocolVersion`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message