cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasobrown <...@git.apache.org>
Subject [GitHub] cassandra pull request #255: Marcuse/14618
Date Wed, 29 Aug 2018 14:03:11 GMT
Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/255#discussion_r213674616
  
    --- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultComparator.java ---
    @@ -0,0 +1,122 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.tools.fqltool;
    +
    +
    +import java.util.List;
    +import java.util.Objects;
    +import java.util.stream.Collectors;
    +
    +import com.google.common.collect.Streams;
    +
    +public class ResultComparator
    +{
    +    /**
    +     * Compares the rows in rows
    +     * the row at position x in rows will have come from host at position x in targetHosts
    +     */
    +    public boolean compareRows(List<String> targetHosts, FQLQuery query, List<ResultHandler.ComparableRow>
rows)
    +    {
    +        if (rows.size() < 2 || rows.stream().allMatch(Objects::isNull))
    +            return true;
    +
    +        if (rows.stream().anyMatch(Objects::isNull))
    +        {
    +            handleMismatch(targetHosts, query, rows);
    +            return false;
    +        }
    +
    +        ResultHandler.ComparableRow ref = rows.get(0);
    +        boolean equal = true;
    +        for (int i = 1; i < rows.size(); i++)
    --- End diff --
    
    I think this might overlog. If you have greater than two elements in `rows`, and the first
element (`ref`) differs from the rest of `rows`, the full log entry (via `handleMismatch()`)
will be printed `n - 1` times. This is because `handleMismatch()` prints the entire `rows`.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message