From pr-return-1033-apmail-cassandra-pr-archive=cassandra.apache.org@cassandra.apache.org Wed Aug 29 06:27:37 2018 Return-Path: X-Original-To: apmail-cassandra-pr-archive@minotaur.apache.org Delivered-To: apmail-cassandra-pr-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 680751DE02 for ; Wed, 29 Aug 2018 06:27:37 +0000 (UTC) Received: (qmail 96821 invoked by uid 500); 29 Aug 2018 06:27:37 -0000 Delivered-To: apmail-cassandra-pr-archive@cassandra.apache.org Received: (qmail 96724 invoked by uid 500); 29 Aug 2018 06:27:37 -0000 Mailing-List: contact pr-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: pr@cassandra.apache.org Delivered-To: mailing list pr@cassandra.apache.org Received: (qmail 96590 invoked by uid 99); 29 Aug 2018 06:27:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2018 06:27:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0D204DFC7C; Wed, 29 Aug 2018 06:27:36 +0000 (UTC) From: jasobrown To: pr@cassandra.apache.org Reply-To: pr@cassandra.apache.org References: In-Reply-To: Subject: [GitHub] cassandra pull request #255: Marcuse/14618 Content-Type: text/plain Message-Id: <20180829062736.0D204DFC7C@git1-us-west.apache.org> Date: Wed, 29 Aug 2018 06:27:36 +0000 (UTC) Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213547995 --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQueryIterator.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.fqltool; + +import java.util.PriorityQueue; + +import net.openhft.chronicle.queue.ExcerptTailer; +import org.apache.cassandra.utils.AbstractIterator; + +public class FQLQueryIterator extends AbstractIterator +{ + private final PriorityQueue pq; --- End diff -- Please add a small comment here as to why a `PriorityQueue` ("so we can sort the entries by timestamp of the query in logs, not just the order in the file"). This would just be a nice, quick little helper. --- --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org For additional commands, e-mail: pr-help@cassandra.apache.org