From pr-return-1069-apmail-cassandra-pr-archive=cassandra.apache.org@cassandra.apache.org Fri Aug 31 13:00:07 2018 Return-Path: X-Original-To: apmail-cassandra-pr-archive@minotaur.apache.org Delivered-To: apmail-cassandra-pr-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 001CB21729 for ; Fri, 31 Aug 2018 13:00:06 +0000 (UTC) Received: (qmail 5681 invoked by uid 500); 31 Aug 2018 13:00:06 -0000 Delivered-To: apmail-cassandra-pr-archive@cassandra.apache.org Received: (qmail 5655 invoked by uid 500); 31 Aug 2018 13:00:06 -0000 Mailing-List: contact pr-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: pr@cassandra.apache.org Delivered-To: mailing list pr@cassandra.apache.org Received: (qmail 5633 invoked by uid 99); 31 Aug 2018 13:00:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Aug 2018 13:00:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 20385E04C9; Fri, 31 Aug 2018 13:00:06 +0000 (UTC) From: jasobrown To: pr@cassandra.apache.org Reply-To: pr@cassandra.apache.org References: In-Reply-To: Subject: [GitHub] cassandra pull request #256: Marcuse/14619 Content-Type: text/plain Message-Id: <20180831130006.20385E04C9@git1-us-west.apache.org> Date: Fri, 31 Aug 2018 13:00:06 +0000 (UTC) Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/256#discussion_r214339180 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Compare.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.fqltool.commands; + + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.stream.Collectors; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.collect.AbstractIterator; + +import io.airlift.airline.Arguments; +import io.airlift.airline.Command; +import io.airlift.airline.Option; +import net.openhft.chronicle.core.io.Closeable; +import net.openhft.chronicle.queue.ChronicleQueue; +import net.openhft.chronicle.queue.ChronicleQueueBuilder; +import net.openhft.chronicle.queue.ExcerptTailer; +import org.apache.cassandra.tools.fqltool.FQLQueryIterator; +import org.apache.cassandra.tools.fqltool.ResultHandler; +import org.apache.cassandra.tools.fqltool.StoredResultSet; + +/** + */ +@Command(name = "compare", description = "Compare result files generated by fqltool replay") +public class Compare implements Runnable +{ + @Arguments(usage = " [...]", description = "Directories containing result files to compare.", required = true) + private List arguments = new ArrayList<>(); + + @Option(title = "queries", name = { "--queries"}, description = "Where to read the queries - should be produced by the replay command --store-queries to make sure they are in the same order") --- End diff -- `queries` should be marked as `required=true`, as well. --- --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org For additional commands, e-mail: pr-help@cassandra.apache.org