cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...
Date Wed, 05 Sep 2018 21:41:24 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/257#discussion_r215434653
  
    --- Diff: src/java/org/apache/cassandra/repair/RepairRunnable.java ---
    @@ -651,7 +651,7 @@ private static void addRangeToNeighbors(List<CommonRange> neighborRangeList,
Ran
             for (CommonRange cr : neighborRangeList)
             {
                 // Use strict equality here, as worst thing that can happen is we generate
one more stream
    -            if (Iterables.elementsEqual(cr.endpoints, endpoints) && Iterables.elementsEqual(cr.transEndpoints,
transEndpoints))
    +            if (Sets.difference(cr.endpoints, endpoints).isEmpty() && Sets.difference(cr.transEndpoints,
transEndpoints).isEmpty())
    --- End diff --
    
    You can use .equals() here. Set equality does the right thing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message