cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdeggleston <...@git.apache.org>
Subject [GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...
Date Wed, 05 Sep 2018 23:28:22 GMT
Github user bdeggleston commented on the issue:

    https://github.com/apache/cassandra/pull/257
  
    I think I've mostly convinced myself this is all you need to do to support coordinating
repairs for locally transient ranges. I have a commit [here](https://github.com/bdeggleston/cassandra/tree/alexp/tr-followup-1-updates)
here with a few adjustments:
    
    * Move set comparison logic in RepairRunnable#addRangeToNeighbors to CommonRange class

    * changed asserts to Preconditions
    * added a SymmetricLocalSync task test for the local transient case
    * misc formatting
    
    This leaves the sync task class hierarchy in kind of a messy state. We have AsymmetricSyncTask,
but we also have SymmetricSyncTask which can also function as an asymmetric sync task. I do
think the state of things is preferable to adding more branches to RepairJob#standardSyncing
though, and a refactor is out of scope for this ticket. I'll open a follow on jira to clean
that up once this is committed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message