Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r215733891
--- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java
---
@@ -36,6 +37,11 @@
public class RebufferingByteBufDataInputPlus extends RebufferingInputStream implements
ReadableByteChannel
{
+ /**
+ * Default to a very large value.
+ */
+ private static final long DEFAULT_REBUFFER_BLOCK_IN_MILLIS = TimeUnit.DAYS.toMillis(2);
--- End diff --
Its risky to default to a very large value. Why do we want to default to such a large
value?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
|