cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #253: 13630
Date Fri, 07 Sep 2018 06:06:21 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/253#discussion_r215735492
  
    --- Diff: src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java
---
    @@ -393,6 +393,18 @@ private Channel getOrCreateChannel()
                 }
             }
     
    +        private void onError(Throwable t)
    +        {
    +            try
    +            {
    +                session.onError(t).get(5, TimeUnit.MINUTES);
    --- End diff --
    
    Why do we have a 5 minute timeout? We should pull this out as a constant.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message