cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasobrown <...@git.apache.org>
Subject [GitHub] cassandra pull request #253: 13630
Date Fri, 07 Sep 2018 12:17:39 GMT
Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/253#discussion_r215939675
  
    --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java
---
    @@ -36,6 +37,11 @@
     
     public class RebufferingByteBufDataInputPlus extends RebufferingInputStream implements
ReadableByteChannel
     {
    +    /**
    +     * Default to a very large value.
    +     */
    +    private static final long DEFAULT_REBUFFER_BLOCK_IN_MILLIS = TimeUnit.DAYS.toMillis(2);
    --- End diff --
    
    The corresponding pre-4.0 code just does blocking IO on a socket, with no timeouts. Thus
it blocks forever. 2 days seems shorter than forever, but I'm game to change this to any time-bounded
value.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message