cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #253: 13630
Date Fri, 07 Sep 2018 21:03:10 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/253#discussion_r216086521
  
    --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java
---
    @@ -36,6 +37,11 @@
     
     public class RebufferingByteBufDataInputPlus extends RebufferingInputStream implements
ReadableByteChannel
     {
    +    /**
    +     * Default to a very large value.
    +     */
    +    private static final long DEFAULT_REBUFFER_BLOCK_IN_MILLIS = TimeUnit.DAYS.toMillis(2);
    --- End diff --
    
    I think it doesn't make sense to wait for more than 5 minutes to rebuffer. Given buffer
sizes are on the order of a few megabytes at most, 5 minutes is an eternity. It's best to
keep it short so failures are exposed sooner than later and rather than threads being stuck
waiting on a call that doesn't timeout in a reasonable amount of time.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message