cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra pull request #253: 13630
Date Fri, 07 Sep 2018 23:09:51 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/253#discussion_r216098891
  
    --- Diff: src/java/org/apache/cassandra/net/async/ByteBufDataOutputStreamPlus.java ---
    @@ -196,10 +220,12 @@ protected void doFlush(int count) throws IOException
                 int byteCount = buffer.position();
                 currentBuf.writerIndex(byteCount);
     
    -            if (!Uninterruptibles.tryAcquireUninterruptibly(channelRateLimiter, byteCount,
2, TimeUnit.MINUTES))
    +            if (!Uninterruptibles.tryAcquireUninterruptibly(channelRateLimiter, byteCount,
rateLimiterBlockTime, rateLimiterBlockTimeUnit))
    --- End diff --
    
    This is going up from 2 minutes to potentially 5 minutes. I think this should be ok but
just making sure.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message