cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasobrown <...@git.apache.org>
Subject [GitHub] cassandra pull request #253: 13630
Date Sun, 09 Sep 2018 13:13:53 GMT
Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/253#discussion_r216157094
  
    --- Diff: src/java/org/apache/cassandra/net/async/ByteBufDataOutputStreamPlus.java ---
    @@ -196,10 +220,12 @@ protected void doFlush(int count) throws IOException
                 int byteCount = buffer.position();
                 currentBuf.writerIndex(byteCount);
     
    -            if (!Uninterruptibles.tryAcquireUninterruptibly(channelRateLimiter, byteCount,
2, TimeUnit.MINUTES))
    +            if (!Uninterruptibles.tryAcquireUninterruptibly(channelRateLimiter, byteCount,
rateLimiterBlockTime, rateLimiterBlockTimeUnit))
    --- End diff --
    
    Good catch. ftr, the only place where this went from 2 up to 5 minutes was in `NettyStreamingMessageSender.FIleSendTask`
where I [defaulted to 5 minutes](https://github.com/apache/cassandra/pull/253/files#diff-6d6dd6c9e52acdc8462538a0d3695c0aR327).
I've switched that call site to default to 2 minutes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message