cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #262: Replicalayout followup
Date Mon, 10 Sep 2018 16:19:17 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/262#discussion_r216384748
  
    --- Diff: src/java/org/apache/cassandra/batchlog/BatchlogManager.java ---
    @@ -459,36 +458,31 @@ private void writeHintsForUndeliveredEndpoints(int startFrom, Set<InetAddressAnd
                 Keyspace keyspace = Keyspace.open(ks);
                 Token tk = mutation.key().getToken();
     
    +
                 ReplicaLayout.ForTokenWrite liveAndDown = ReplicaLayout.forTokenWriteLiveAndDown(keyspace,
tk);
                 Replicas.temporaryAssertFull(liveAndDown.all()); // TODO in CASSANDRA-14549
     
    -            EndpointsForToken.Builder liveReplicasBuilder = EndpointsForToken.builder(tk);
    +            Replica selfReplica = liveAndDown.all().selfIfPresent();
    +            if (selfReplica != null)
    --- End diff --
    
    What exactly is this corner case where we have a hint written to ourselves? I thought
we don't hint ourselves.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message