Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/265#discussion_r216434289
--- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java ---
@@ -196,7 +196,7 @@ public static AbstractReadExecutor getReadExecutor(SinglePartitionReadCommand
co
// There are simply no extra replicas to speculate.
// Handle this separately so it can record failed attempts to speculate due to
lack of replicas
- if (replicaPlan.contact().size() >= replicaPlan.liveOnly().all().size())
+ if (replicaPlan.contact().size() == replicaPlan.candidates().size())
--- End diff --
So >= is not necessary because contact should be a subset of candidates (or it should
be an unavailable)? Is it more robust to use >= in case that doesn't hold due to a mistake
or have an assertion for that?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
|